-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add noUnusedParameters config #2960
Conversation
Deploy preview for ng-zorro-master ready! Built with commit a669af6 |
Codecov Report
@@ Coverage Diff @@
## master #2960 +/- ##
==========================================
+ Coverage 97.35% 97.36% +<.01%
==========================================
Files 529 529
Lines 11081 11081
Branches 803 803
==========================================
+ Hits 10788 10789 +1
+ Misses 183 182 -1
Partials 110 110
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
log(...args: any[]): void { | ||
if (this._loggerState) { | ||
// console.log(...args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilsoncook plz check this.
* build: add noUnusedLocals config * build: add noUnusedParameters config
* build: add noUnusedLocals config * build: add noUnusedParameters config
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Add
noUnusedParameters
to tsconfig.Does this PR introduce a breaking change?
Other information
Please merge #2959 before merging this.